[RFC-007] Implement GitHub app authentication for git repositories in IAC#780
[RFC-007] Implement GitHub app authentication for git repositories in IAC#780matheuscscp merged 1 commit intofluxcd:mainfrom dipti-pai:github-app-auth
Conversation
|
@dipti-pai please rebase with main, it contains the latest auth and git packages with GitHub App support. |
|
@dipti-pai Please rebase once again 🙏 To easily resolve the conflict in I have tested this PR with a private GH repo and a GH app with write access to only this repo and it works 👌
|
|
@dipti-pai I'm so sorry I asked you to rebase the other day, we could have waited until source-controller was released 😅 source-controller 1.5.0 is now released and bumped in the dependencies already, so if you rebase one last time and remove the temporary dependency on your fork we can finally merge this PR 🙏 |
… IAC - Controller change to use the GitHub authentication information specified in Git Repository's `.spec.secretRef` to create the auth options to authenticate to git repositories when the `provider` field is set to `github`, - Tests for new `github` provider field in IAC - Updated docs to use GitHub Apps for authentication in image-automation-controller. Signed-off-by: Dipti Pai <[email protected]>
No worries at all. Rebased again. Thanks. |
5 participants
gitrepository.spec.secretRefto create the auth options to authenticate to git repositories when thegitrepository.spec.providerfield is set togithub,githubprovider field in IAC